-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder changes to input value in readonly input. #34040
Conversation
Thanks! Could you check there're no other occurrencies of such readonly inputs missing a value, either in the docs or the examples, please? If not, we'll take care of it 🙂 |
@ffoodd - yes, I think changes to the CSS are needed too. If you change the placeholder to a value then the displayed 'Readonly input here...' text is not the lighter grey as the Disabled inputs above. Screenshot here by changing the HTML elements in Dev Tools (Edge 90 for Windows): |
@coliff AFAIC that's acceptable since:
@rajesh2kumar96 Were you able to check if there were other |
going purely by WCAG, nominally disabled fields / controls are exempted from 4.5:1 (regular) / 3:1 (large) contrast requirements. readonly fields aren't. even for disabled fields, a ratio of at least 3:1 or better is still best practice, the closer it can get to 4.5:1, the better. beyond that, it's down to aesthetic choices. |
I will do this. |
@ffoodd I changed readonly inputs with value. Please check. |
* placeholder changes to input value * Fix content and add value to readOnly input * add value in readonly input * Update site/content/docs/5.0/forms/form-control.md Co-authored-by: Rajesh Kumar <https://github.com/rajesh2kumar96> Co-authored-by: Patrick H. Lauke <[email protected]> Co-authored-by: Mark Otto <[email protected]>
Fixes #34017