Revert "Allow individual grid classes to override .row-cols"
#34612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
approved these changes
Jul 28, 2021
|
Because #33621 causes such a significant regression when going from 5.0.1 to 5.0.2, I think the reversion should be a hot fix, perhaps released by itself as 5.0.3, and not delayed for 5.1.0. |
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
Aug 18, 2021
…3621)" (twbs#34612) This reverts commit f2b47e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #33621.
Rather than go through the motions of splitting our grid, no generating some classes, or generating different classes in different places, I'm proposing we revert this outright and address it properly when we can devote the time to it. Right now this breaks too many things and I'm not sure what the best solution is just yet.
Fixes #34611, fixes #34564, fixes #34335, fixes #34363.