-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert tooltips and popovers to CSS vars #34622
Conversation
bcb720d
to
acd491e
Compare
4225950
to
439718e
Compare
b12a8e0
to
55b664e
Compare
55b664e
to
eb3ce56
Compare
Regarding Note: regarding my suggestion PR using fallback values, we might check that value is above |
51a6660
to
cf5d1af
Compare
cf5d1af
to
f9658e4
Compare
Updated this PR to also split the padding values for tooltips, popover headers, and popover bodies. |
d96e109
to
78a37f8
Compare
78a37f8
to
e1acfed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single question regarding browser support, but looks great already :)
e1acfed
to
8804395
Compare
7fe4833
to
f7f7a35
Compare
Summary
This PR starts the process of migrating tooltips and popovers to use CSS variables. In doing so, I've deprecated three Sass variables in an effort to improve customization via CSS variables. See
_variables.scss
for the changes there.Beyond that, this replaces the bulk of our Sass for tooltips and popovers with customizable CSS variables. Most are reassigned from the Sass variables and respect the same name, but as mentioned above, some deviation was required for a more sensible future friendly path.
Originally I expected tooltips and popovers to be a clusterfuck to customize, but thanks to the
customClass
option we recently added, this is basically a breeze. I've added the data attributes, wrote some basic styles, and added some lovely docs to explain and demonstrate the situation for folks.Fixes #34221.
Preview
Todos
fusv
doesn't do that for us)