-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't override CSS direction
in code elements
#35230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, some others tweaks can be done afterward but this should be done first and as soon as possible.
Thanks! Could you elaborate why |
Can we have this first in then discuss that if necessary? I really didn't want to open the discussion for it here, what I really meant
The attached image in the WebKit bug shows the issue, to recreate it here say someone writes the following,
It will result in: Abcasd But using isolate or something alike turns it to this which obviously is the intention: Abcasd Ofc whether |
direction
in code elements
Later versions of Bootstrap don't have it. See twbs/bootstrap#35230
Fixes #35219
RTL users can now use the
dir
attribute if they need to display LTR code, but we don't assume this as a default anymore.