Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing scss/maps imports #35373

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

julien-deramond
Copy link
Member

Maybe I'm wrong in my imports, but after the merge of 9f099d3, some bootstrap/scss/maps imports seem to be missing and to create errors:

Error: Undefined variable.
    ╷
358 │       values: $negative-spacers
    │               ^^^^^^^^^^^^^^^^^
    ╵
  bootstrap/scss/_utilities.scss 358:15  @import
  scss/custom.scss 36:9                  root stylesheet

or

Error: Undefined variable.
   ╷
20 │   @each $color, $value in $theme-colors-rgb {
   │                           ^^^^^^^^^^^^^^^^^
   ╵
  bootstrap/scss/_root.scss 20:27  @import
  scss/custom.scss 35:9            root stylesheet

@ffoodd
Copy link
Member

ffoodd commented Nov 20, 2021

I'm pretty sure it's tackled in another PR already but cannot retrieve it for now. 🤔

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is required and I'm unable to find another PR that would introduce the same fix.

@XhmikosR If you recall one, feel free to close this.

@XhmikosR
Copy link
Member

It's probably a mistake. I can't find another PR so let's land this and we can revisit later.

@XhmikosR XhmikosR merged commit 7edad94 into twbs:main Nov 23, 2021
@julien-deramond julien-deramond deleted the main-jd-missing-maps-imports branch November 23, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants