Add missing border-radius for btn-group
#35467
Conversation
Thanks for letting me know. I've addressed the changes, please take another look when you get a chance to. Thanks! Additionally, since I'm a first-time contributor for this repo, I need a maintainer to approve running workflows. |
scss/_button-group.scss
Outdated
| @@ -34,6 +34,9 @@ | |||
| } | |||
|
|
|||
| .btn-group { | |||
| // Prevent white corners if shadow or shadow-lg property applied | |||
There was a problem hiding this comment.
This comment isn't really needed, the property and value speak for themselves.
Then I guess it'd be good to go 👌
|
Addressed linting issue for border-radius on the property-disallowed-list |
scss/_button-group.scss
Outdated
| @@ -34,6 +34,8 @@ | |||
| } | |||
|
|
|||
| .btn-group { | |||
| border-radius: $btn-border-radius; | |||
There was a problem hiding this comment.
It'd be better to use the dedicated mixin instead of disabling the stylelint rule. We wouldn't use the rule if we needed to disable it all the time.
Moreover the mixin will only compute the property when $enable-rounded is true, to respect global setting and stay aligned with buttons styles.
In that case:
| border-radius: $btn-border-radius; | |
| @include border-radius($btn-border-radius); |
And that'd be perfect!
Sorry for the several changes, thanks a lot for your patience!
There was a problem hiding this comment.
Gotcha, understood! No worries, addressed the changes!
XhmikosR
changed the title
border-radius for btn-group
Fixes the border-radius for btn-group
Fixes #34598