Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Popover test that randomly fails on BrowserStack #35757

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jan 31, 2022

Refs #35659

@GeoSot GeoSot requested a review from a team as a code owner January 31, 2022 14:19
@XhmikosR
Copy link
Member

XhmikosR commented Feb 1, 2022

It seems there are still failures :/

@GeoSot
Copy link
Member Author

GeoSot commented Feb 1, 2022

But not on the same test. Right?

@XhmikosR
Copy link
Member

XhmikosR commented Feb 1, 2022

If you mean the popover one, I don't think that fails anymore.

@XhmikosR XhmikosR removed the js label Feb 1, 2022
@XhmikosR XhmikosR changed the title Change popover test that randomly fails on browserstack Fix Popover test that randomly fails on BrowserStack Feb 1, 2022
@GeoSot
Copy link
Member Author

GeoSot commented Feb 1, 2022

Right. popover failure was meant to fix here

@XhmikosR XhmikosR merged commit 3f7b31e into main Feb 1, 2022
@XhmikosR XhmikosR deleted the gs/fix-test branch February 1, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants