Make event name helper and use it on tooltip & popover to reduce dist sizes #35856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two ideas come to mind. 1) Use |
alecpl
reviewed
Feb 17, 2022
| @@ -301,7 +286,7 @@ class Tooltip extends BaseComponent { | |||
| } | |||
|
|
|||
| this._element.removeAttribute('aria-describedby') | |||
| EventHandler.trigger(this._element, this.constructor.Event.HIDDEN) | |||
| EventHandler.trigger(this._element, this.constructor.eventName(EVENT_HIDDEN)) | |||
There was a problem hiding this comment.
I don't know, but can't this be this.eventName instead of this.constructor.eventName everywhere?
There was a problem hiding this comment.
We need to call it statically so we can use it outside the class (at least to what I have seen till now)
Totally aligned with your idea. I want to take it bit by bit to keep PR with few changes. In case it merged, it will be easier to continue change other components |
XhmikosR
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.