Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add z-index for .toast-container #35859

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Add z-index for .toast-container #35859

merged 2 commits into from
Feb 25, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 17, 2022 •
edited by ffoodd
Loading

  • Adds positioning and z-index to toast container so that it has a system-declared layer in relation to other components.
  • Updates docs to use the class better

Fixes #34028

@mdo mdo requested a review from a team as a code owner February 17, 2022 03:49
ffoodd
ffoodd approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a single comment regarding inline styles but I think it's already safe as-is.

mdo added 2 commits February 25, 2022 08:44
@mdo
Add z-index for .toast-container
5ab78e2 
- Adds positioning and z-index to toast container so that it has a system-declared layer in relation to other components.
- Updates docs to use the class better

Fixes $34028
@mdo
Remove unnecessary z-index from docs examples
d276fc1
@mdo mdo merged commit 28d9aaf into main Feb 25, 2022
@mdo mdo deleted the toast-zindex branch February 25, 2022 16:49
@louismaximepiton louismaximepiton mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast is hidden under offcanvas
2 participants
@mdo @ffoodd