New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve use of CSS vars in Toasts #36145

Merged

mdo merged 1 commit into twbs:main from julien-deramond:main-jd-improve-use-of-css-vars-in-toasts

Apr 11, 2022

Member

julien-deramond commented Apr 11, 2022 •

edited

Loading

Description

Create a new --bs-toast-spacing CSS var linked to $toast-spacing
Use --bs-toast-font-size in @include font-size()

Motivation & Context

Get rid of all remaining $toast-* SCSS vars in _toasts.scss.

Types of changes

Refactoring (non-breaking change)

Checklist

I have read the contributing guidelines
My code follows the code style of the project (using npm run lint)
My change introduces changes to the documentation
I have updated the documentation accordingly
All new and existing tests passed

Related issues

N/A

Live preview

julien-deramond requested a review from a team as a code owner

April 11, 2022 10:04

mdo approved these changes

View reviewed changes

Member

mdo left a comment

<3

mdo added css v5 labels


          Improve use of CSS vars in Toasts

23b5016

mdo force-pushed the main-jd-improve-use-of-css-vars-in-toasts branch from 109c2e9 to 23b5016 Compare

April 11, 2022 22:33

mdo merged commit a58d894 into twbs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels