Doc: Uniformization of nav tabs content panes #36163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
GeoSot
reviewed
Apr 13, 2022
| @@ -346,13 +346,13 @@ Use the tab JavaScript plugin—include it individually or through the compiled | |||
| </ul> | |||
| <div class="tab-content" id="myTabContent"> | |||
| <div class="tab-pane fade show active" id="home" role="tabpanel" aria-labelledby="home-tab" tabindex="0"> | |||
| <p><strong>This is some placeholder content the Home tab's associated content.</strong> Clicking another tab will toggle the visibility of this one for the next. The tab JavaScript swaps classes to control the content visibility and styling. You can use it with tabs, pills, and any other <code>.nav</code>-powered navigation. No1</p> | |||
| <p><strong>This is some placeholder content the Home tab's associated content.</strong> Clicking another tab will toggle the visibility of this one for the next. The tab JavaScript swaps classes to control the content visibility and styling. You can use it with tabs, pills, and any other <code>.nav</code>-powered navigation.</p> | |||
There was a problem hiding this comment.
I can understand the thought, but I would prefer at least, to emphasize only the different words and not the whole sentence.
(As you rightly imagined, as I developed this, I couldn't focus on the differences)
There was a problem hiding this comment.
Yep good point! I've emphasized only <strong>Home tab's</strong> instead of the whole sentence in d711e82.
However I'm not sure if it wouldn't be better in English to emphasize only <strong>Home</strong> or <strong>Home tab</strong>'s in good English 🤷
There was a problem hiding this comment.
I prefer it as you did it. @mdo are you fine with it?
julien-deramond
force-pushed
the
main-jd-uniformization-of-nav-tabs-content-panes
branch
from
2fb73b6 to
e53f0c3
Compare
julien-deramond
force-pushed
the
main-jd-uniformization-of-nav-tabs-content-panes
branch
from
e53f0c3 to
d711e82
Compare
GeoSot
approved these changes
Apr 13, 2022
mdo
approved these changes
Apr 13, 2022
julien-deramond
deleted the
main-jd-uniformization-of-nav-tabs-content-panes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to uniformize the nav tabs content panes in the "Navs and tabs" page.
The removed texts are probably a leftover of tests during the development.
Live preview