Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert backdrop utilization, handling clicks over modal #36324

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented May 11, 2022

closes #36295

@GeoSot GeoSot requested review from a team as code owners May 11, 2022 00:14
@GeoSot GeoSot changed the title Revert backdrop utilazition to handle clicks over m… Revert backdrop utilization, handling clicks over modal May 11, 2022
@GeoSot GeoSot added the p1 Critical, and inhibits core functionality label May 11, 2022
@mdo
Copy link
Member

mdo commented May 13, 2022

Thanks for this! <3

GeoSot and others added 2 commits May 12, 2022 21:09
…odal

* Revert #35554 and backdrop callback usage
  Explanation: In order to bypass `.modal`, was applied a css rule `pointer-events:none` which caused the side effect, and user couldn't scroll "long content modals"
@mdo mdo force-pushed the gs/revert-36295 branch from df47723 to b781965 Compare May 13, 2022 04:09
@mdo mdo merged commit b167420 into main May 13, 2022
@mdo mdo deleted the gs/revert-36295 branch May 13, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-main-branch js p1 Critical, and inhibits core functionality v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long content scrolling in v5.2.0 Modal does not work
2 participants