Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update masthead to HeroDevs EOL #39749

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

edezekiel
Copy link
Contributor

@edezekiel edezekiel commented Mar 6, 2024

Description

Updated homepage of getbootstrap.com , add yellow banner on the top of the page with link to HeroDevs.

Motivation & Context

Introduces Never-Ending Support for Bootstrap.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@edezekiel edezekiel changed the title feat(masthead): Update masthead to HeroDevs EOL Update masthead to HeroDevs EOL Mar 6, 2024
@julien-deramond julien-deramond marked this pull request as draft March 7, 2024 14:44
@jwcalles
Copy link

jwcalles commented Mar 7, 2024

@mdo here is the adjustment to the homepage that we discussed. Adding the masthead/banner pointing potential Bootstrap v3 and v4 users to the extended long-term support offering.

@edezekiel on our team put the PR together for your review, happy to make any required changes or edits.

@mdo mdo marked this pull request as ready for review March 14, 2024 00:11
@mdo mdo added the docs label Mar 14, 2024
@mdo mdo force-pushed the herodevs-never-ending-support-links branch from 1a96a37 to 88e4683 Compare March 14, 2024 00:24
@mdo mdo added the v5 label Mar 14, 2024
@aavorthmann
Copy link

@mdo is there anything I can help with on this one? Do I need to request a specific reviewer ?

@mdo mdo mentioned this pull request Mar 15, 2024
@mdo mdo merged commit 086a0e2 into twbs:main Mar 15, 2024
14 checks passed
@mdo
Copy link
Member

mdo commented Mar 15, 2024

Manually added to gh-pages in #39787. This PR ensures we'll have it in our next release as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants