Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39817 issue to add outlined badges #40606

Closed
wants to merge 2 commits into from

Conversation

deepeshagarwal150106
Copy link

@deepeshagarwal150106 deepeshagarwal150106 commented Jul 3, 2024

Description

added outlined badges

Motivation & Context

it improve badge feature

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39817 [feature request] outlined badges

@deepeshagarwal150106 deepeshagarwal150106 requested a review from a team as a code owner July 3, 2024 10:48
@julien-deramond julien-deramond self-requested a review July 3, 2024 10:50
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR @deepeshagarwal150106

I'm going to close it as it is for now, too far from what's expected in terms of content.

Please, feel free to create a new one whenever the following points will be tackled:

  • A new variant of a component must be documented
  • We never use hexadecimal values directly in components Sass files, we rely on other Sass or CSS semantic color variables
  • Instead of declaring x times a .badge-outline-* class, a Sass loop should be used from the map that contains the different semantic colors (see other components like this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Outlined badges
2 participants