Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update WCAG links and references #40703

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 7, 2024

Description

Update all the WCAG links and references from 2.1 to 2.2.

Motivation & Context

Be up to date with the last version of the WCAG.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These modifications look good to me, the links go to the same corresponding content in WCAG 2.2, and using "/WCAG/" (without the version) is better IMO.

There's a change that could be done also in scss/mixins/_visually-hidden.scss:

diff --git a/scss/mixins/_visually-hidden.scss b/scss/mixins/_visually-hidden.scss
index 082aeec95..388916ccf 100644
--- a/scss/mixins/_visually-hidden.scss
+++ b/scss/mixins/_visually-hidden.scss
@@ -24,7 +24,7 @@
 // Use to only display content when it's focused, or one of its child elements is focused
 // (i.e. when focus is within the element/container that the class was applied to)
 //
-// Useful for "Skip to main content" links; see https://www.w3.org/TR/2013/NOTE-WCAG20-TECHS-20130905/G1
+// Useful for "Skip to main content" links; see https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html
 
 @mixin visually-hidden-focusable() {
   &:not(:focus):not(:focus-within) {

@julien-deramond julien-deramond self-requested a review August 7, 2024 09:16
@julien-deramond
Copy link
Member

Handing it over to @patrickhlauke for final review

@julien-deramond julien-deramond merged commit 3083596 into main Aug 7, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-update-wcag-links branch August 7, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants