Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate makefile step confirmation #6968

Merged
merged 10 commits into from
Mar 1, 2013
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 18, 2013

This is an updated pull request based on #6576 by @dudebout. It merges his changes with our latest makefile modifications and aims to provide more accurate and realtime step feedback with a separated "✔ Done" confirmation.

/cc @fat

dudebout and others added 10 commits January 14, 2013 08:57
The echo command does not understand the -n argument on Mac OS X.
This is due to the fact that:

  - Makefile calls /bin/sh to execute a command
  - in Mac OS X, /bin/sh is a link to bash
  - in Mac OS X, bash is compiled with --enable-strict-posix-default

Therefore, the echo command does not have the -n argument.

printf on the other hand is a builtin function that works well on Mac OS X and Linux.
The change introduced in 5bd8cdc was:

  - partial, as not all the command were translated
  - preventing the use of a global npm installation
A user can use the following command to determine where to copy the resulting css file:

    $ BOOTSTRAP=<my-path> make
mdo added a commit that referenced this pull request Mar 1, 2013
More accurate makefile step confirmation
@mdo mdo merged commit 6e0815b into 3.0.0-wip Mar 1, 2013
@dudebout
Copy link
Contributor

dudebout commented Mar 1, 2013

Thank you

@mdo mdo mentioned this pull request Mar 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants