Separate push, pull, offset for Large and Small grids #8974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a discussion going on about this, but I had to fix the problem to get our theme working with Bootstrap 3.
If you're going to have multiple grids, you have to do pushes, pulls, and offsets for both grids separately. I really don't see a way around this. Consider the following:
(also available as a fiddle)
This is going on the traditional "info bar" at the bottom of every page, look at the bottom of any modern web page to see what I'm talking about. On tablet and large screens, I want the corporate logo to be centered. On the tablet, the logo can be a little bigger, because I'm going to hide some of the text in the info boxes.
However, there is currently no way whatsoever to specify that the pushing and pulling is different on the small grid. If the small grid is set to the same as the large grid (col-lg-5, col-sm-5, col-push-2) of course it works just fine. But if the grid changes for tablets, then push, pull, and offset all break miserably.
With this patch, you can change the above code to:
Classes get a bit cluttered, but honestly I see no other way to do this.