-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: switch to modules #1663
build: switch to modules #1663
Conversation
I prefer modules, mostly because I work with Typescript a lot in which they're the default. I've always found the Edit: It seems like the mjs extension is still necessary if you don't specify |
The reason I went with mjs is so that we don't need to specify |
Yes, I agree. After all these are just a few build scripts so changing the whole projects module system wouldn't be a good idea. |
Cool, I'll try to do the same changes in the bootstrap repo and then land this one :) |
I'll revisit this when I'm done with the upstream changes so that we have the same point of reference. |
@korki43 do you have any opinion? Modules are inherently faster :)