-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop SVG sprite for font on docs homepage #824
Conversation
Not sure if this improves things a lot. I mean, it certainly reduces the total bytes downloaded, but I believe the culprit is the HTML size/number of DOM elements, which is still the same. That being said, from a quick look, it shouldn't hurt.
Give me a few days to test this out :) |
No rush! Appreciate the eyes on it. I'd also be in favor of keeping SVGs and showing things differently on the homepage. Maybe show latest release or specific categories? Or show them all by categories? Open to ideas. |
fa317d0
to
a5b19e0
Compare
@mdo LGTM, let's land it. My only suggestion would be to maybe add a new sprite page later so that we have a visual test for the sprite? |
5421bdc
to
eeeaa80
Compare
eeeaa80
to
4f60b51
Compare
ba63b96
to
5392a22
Compare
@mdo I pushed some patches, now it looks better I think. If it LGTY too, let's land this :) |
a69094d
to
8f038d7
Compare
03b76c5
to
f30f0be
Compare
We save ~2000 (-16%) DOM elements and ~1.3MB (-45%) uncompressed / ~200KB (-35%) brotli transfer size for homepage. Still far from perfect, but until we figure out a way to use pagination or something else, this should improve things noticeably, especially on slow devices/browsers. |
da20f29
to
f276d9a
Compare
Drop usage of large SVG sprite on homepage and in copy buttons, replacing them with the icon fonts. Goal is to improve performance and page load since the sprite is so large.
TODO:
Preview: