Split the self_test part of the tests into another file #363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix of
self_test
(#123) depending on #362.The
self_test
always failed when we added the functionality of parsingtypeshed
packages liketypes-setuptools
because it wasn't installed in our virtual environment of CI.In our
tests.yaml
, we havebefore
while running fawltydeps against itself needs to install all optional dependencies, including
"nox", "test", "lint", "format", "dev"
, andtypes-setuptools
is a dependency oflint
.We cannot just install the projects with all optional dependencies in
tests.yaml
because in our unit tests, we checkedclick
package as an example, which will be installed when includingformat
, and then thetests/test_install_deps.py::test_resolve_dependencies_install_deps__via_local_cache
will fail because it will useLocalPackageResolver
instead ofTemporaryPipInstallResolver
. (The detailed logs are here)So, after thinking of this, splitting the
self_test
part of thetests
may be a better solution. In this way, in the self test, we install all dependencies and optional dependencies and do a complete test, and in the normaltests
, we do the remaining tests with only"nox"
and"test"
groups installed.