Relax regex re. recognizing requirements.txt #372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zhihan found that the plotly project has some requirements files that
are not recognized by FawltyDeps, with names like
requirements_abc.txt
.Using the underscore as a separator in the filename does not match our
regex, which requires a word boundary (
"\b"
) around the"requirements"
string in the filename.
Fix our regex: There is no reason why the underscore separator should
disqualify this as a requirements file, and simplifying the regex to
".*requirements.*\.(txt|in)"
is unlikely to introduce false positives(files that should not be recognized as
requirements.txt
files, butnow are).
Also add unit tests precisely for parsing filenames of dependency files
as I could not find another test case that tested exactly this.