Support Python v3.12 #383
Merged
Support Python v3.12 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Nour-Mws
approved these changes
Oct 11, 2023
Generated with `poetry lock --no-update` after re-entering the latest nix-shell which upgrades Poetry from v1.4.2.
From https://docs.python.org/3.12/library/venv.html: "Changed in version 3.12: setuptools is no longer a core venv dependency." To pass our test suite on Python v3.12, we must relax our test on what a default virtual environment (e.g. as installed by `python -m venv ...`) should contain. setuptools is no longer installed by Python v3.12, and AFAICS, the only common subset of packages/import names installed by the venv module across all our supported Python versions is "pip"/"pip".
Our current Pylint version crashes when run with Python v3.12, and we need to upgrade to Pylint v3 in order to fix this. However, Pylint v3 removes support for Python v3.7. Hence, Upgrade Pylint to v3 for Python >=v3.8, and remain on the old Pylint version for Python v3.7. In addition to the pyproject.toml/poetry.lock upgrade itself, there are a few new warnings that need silencing in order for our code to pass with the new Pylint version.
jherland
force-pushed
the
jherland/python-3.12
branch
from
c40da9d to
df2e301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly straighforward upgrade of our deps to support Python v3.12. No material changes to our code.
Commits:
shell.nix: Upgradenixpkgsto version that has Python v3.12.0poetry.lock: Refresh with Poetry v1.6.1test_local_env: Relax test on default venv to accomodate Python v3.12