Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our balancing mechanism #393

Closed
mmontin opened this issue May 15, 2024 · 0 comments · Fixed by #417
Closed

Improve our balancing mechanism #393

mmontin opened this issue May 15, 2024 · 0 comments · Fixed by #417

Comments

@mmontin
Copy link
Collaborator

mmontin commented May 15, 2024

For now, we have our own mechanism to balance transactions that operate on our TxSkel. This does multiple things, depending on our skeleton parameters:

  • ensure each output is given a minimal amount of ada depending on the output size
  • compute fees and add them to the transaction
  • add collaterals to the transaction
  • balance the transaction

It is well known that this process is complicated and involves a fixpoint because adding fees will increase the size of the transaction, thus possibly requiring more fees and so on. How we currently handle all of this could be improved in many ways:

  • investigate the use of an external balancing function
  • add proper collateral amount with return collaterals instead of a single big Utxo
  • for now, we can only add governance features after balancing on the actual Cardano transaction. This might be an issue if the fees (which we compute before) depend on the presence of Governance elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant