Introduce new cardano-cli latest transaction build-estimate command
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
cardano-cli latest transaction build-estimate
Usage: cardano-cli latest transaction build-estimate
[ --script-valid
| --script-invalid
]
--shelley-key-witnesses INT
[--byron-key-witnesses Int]
--protocol-params-file FILE
--total-utxo-value VALUE
(--tx-in TX-IN
[ --spending-tx-in-reference TX-IN
( --spending-plutus-script-v2
| --spending-plutus-script-v3
)
( --spending-reference-tx-in-datum-cbor-file CBOR FILE
| --spending-reference-tx-in-datum-file JSON FILE
| --spending-reference-tx-in-datum-value JSON VALUE
| --spending-reference-tx-in-inline-datum-present
)
( --spending-reference-tx-in-redeemer-cbor-file CBOR FILE
| --spending-reference-tx-in-redeemer-file JSON FILE
| --spending-reference-tx-in-redeemer-value JSON VALUE
)
--spending-reference-tx-in-execution-units (INT, INT)
| --simple-script-tx-in-reference TX-IN
| --tx-in-script-file FILE
[
( --tx-in-datum-cbor-file CBOR FILE
| --tx-in-datum-file JSON FILE
| --tx-in-datum-value JSON VALUE
| --tx-in-inline-datum-present
)
( --tx-in-redeemer-cbor-file CBOR FILE
| --tx-in-redeemer-file JSON FILE
| --tx-in-redeemer-value JSON VALUE
)
--tx-in-execution-units (INT, INT)]
])
[--read-only-tx-in-reference TX-IN]
[ --required-signer FILE
| --required-signer-hash HASH
]
[--tx-in-collateral TX-IN]
[--tx-out-return-collateral ADDRESS VALUE]
[--tx-out ADDRESS VALUE
[ --tx-out-datum-hash HASH
| --tx-out-datum-hash-cbor-file CBOR FILE
| --tx-out-datum-hash-file JSON FILE
| --tx-out-datum-hash-value JSON VALUE
| --tx-out-datum-embed-cbor-file CBOR FILE
| --tx-out-datum-embed-file JSON FILE
| --tx-out-datum-embed-value JSON VALUE
| --tx-out-inline-datum-cbor-file CBOR FILE
| --tx-out-inline-datum-file JSON FILE
| --tx-out-inline-datum-value JSON VALUE
]
[--tx-out-reference-script-file FILE]]
--change-address ADDRESS
[--mint VALUE
( --mint-script-file FILE
[
( --mint-redeemer-cbor-file CBOR FILE
| --mint-redeemer-file JSON FILE
| --mint-redeemer-value JSON VALUE
)
--mint-execution-units (INT, INT)]
| --simple-minting-script-tx-in-reference TX-IN
--policy-id HASH
| --mint-tx-in-reference TX-IN
( --mint-plutus-script-v2
| --mint-plutus-script-v3
)
( --mint-reference-tx-in-redeemer-cbor-file CBOR FILE
| --mint-reference-tx-in-redeemer-file JSON FILE
| --mint-reference-tx-in-redeemer-value JSON VALUE
)
--mint-reference-tx-in-execution-units (INT, INT)
--policy-id HASH
)]
[--invalid-before SLOT]
[--invalid-hereafter SLOT]
[--certificate-file FILE
[ --certificate-script-file FILE
[
( --certificate-redeemer-cbor-file CBOR FILE
| --certificate-redeemer-file JSON FILE
| --certificate-redeemer-value JSON VALUE
)
--certificate-execution-units (INT, INT)]
| --certificate-tx-in-reference TX-IN
( --certificate-plutus-script-v2
| --certificate-plutus-script-v3
)
( --certificate-reference-tx-in-redeemer-cbor-file CBOR FILE
| --certificate-reference-tx-in-redeemer-file JSON FILE
| --certificate-reference-tx-in-redeemer-value JSON VALUE
)
--certificate-reference-tx-in-execution-units (INT, INT)
]]
[--withdrawal WITHDRAWAL
[ --withdrawal-script-file FILE
[
( --withdrawal-redeemer-cbor-file CBOR FILE
| --withdrawal-redeemer-file JSON FILE
| --withdrawal-redeemer-value JSON VALUE
)
--withdrawal-execution-units (INT, INT)]
| --withdrawal-tx-in-reference TX-IN
( --withdrawal-plutus-script-v2
| --withdrawal-plutus-script-v3
)
( --withdrawal-reference-tx-in-redeemer-cbor-file CBOR FILE
| --withdrawal-reference-tx-in-redeemer-file JSON FILE
| --withdrawal-reference-tx-in-redeemer-value JSON VALUE
)
--withdrawal-reference-tx-in-execution-units (INT, INT)
]]
[--tx-total-collateral INTEGER]
[--reference-script-size NATURAL]
[ --json-metadata-no-schema
| --json-metadata-detailed-schema
]
[--auxiliary-script-file FILE]
[ --metadata-json-file FILE
| --metadata-cbor-file FILE
]
[--update-proposal-file FILE]
--out-file FILE
Build a balanced transaction without access to a live node (automatically estimates fees) |
Jimbo4350
force-pushed
the
jordan/add-build-cmd-estimate
branch
from
c399f5f to
bcd5053
Compare
carbolymer
reviewed
Apr 18, 2024
|
|
||
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} | ||
| {-# OPTIONS_GHC -fwarn-incomplete-patterns #-} |
There was a problem hiding this comment.
It shouldn't be. I was trying to understand why GHC did not complain about: https://github.com/IntersectMBO/cardano-cli/pull/728/files#diff-a38343c1825e6e334224d0a8a1ba78a458652970f00c54f5fb0d040be28f822eR787
There was a problem hiding this comment.
🥲
┃ │ ━━━━ stderr ━━━━
┃ │
┃ │ cardano-cli: user error (Pattern match failure in 'do' block at src/Cardano/CLI/EraBased/Run/Transaction.hs:787:3-26)
There was a problem hiding this comment.
But there's no pattern matching in that fragment:
validatedTxCerts
<- hoistEither
. first TxCmdTxCertificatesValidationError
$ validateTxCertificates era certsAndMaybeScriptWitsstrange
carbolymer
reviewed
Apr 18, 2024
carbolymer
reviewed
Apr 18, 2024
cardano-cli/test/cardano-cli-golden/files/golden/help/conway_transaction.cli
Show resolved
Hide resolved
Jimbo4350
force-pushed
the
jordan/add-build-cmd-estimate
branch
3 times, most recently
from
085c1e5 to
7c3e048
Compare
carbolymer
approved these changes
Apr 26, 2024
certificates in the transaction
Jimbo4350
force-pushed
the
jordan/add-build-cmd-estimate
branch
from
7c3e048 to
b43bdbe
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| poolsToDeregister = Set.fromList $ catMaybes [getPoolDeregistrationInfo cert | (cert,_) <- certsAndMaybeScriptWits] | ||
| totCol = fromMaybe 0 plutusCollateral | ||
| pScriptExecUnits = Map.fromList [ (sWitIndex, execUnits) | ||
| | (sWitIndex, (AnyScriptWitness (PlutusScriptWitness _ _ _ _ _ execUnits))) <- collectTxBodyScriptWitnesses sbe txBodyContent |
Check notice
Code scanning / HLint
Redundant bracket Note
| estimateBalancedTxBody eon txBodyContent (unLedgerProtocolParameters ledgerPParams) poolsToDeregister | ||
| stakeCredentialsToDeregisterMap drepsToDeregisterMap | ||
| pScriptExecUnits totCol shelleyWitnesses (fromMaybe 0 mByronWitnesses) | ||
| (fromMaybe 0 (unReferenceScriptSize <$> totalReferenceScriptSize)) (anyAddressInShelleyBasedEra sbe changeAddr) |
Check warning
Code scanning / HLint
Use maybe Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist