Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.12: add changelog #1279

Merged
merged 4 commits into from
Mar 16, 2020
Merged

release 0.12: add changelog #1279

merged 4 commits into from
Mar 16, 2020

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 13, 2020

Release checklist: #1278

For the record, I gathered the list of PRs since release 0.11 here: https://github.com/tweag/rules_haskell/pulls?q=is%3Apr+merged%3A%3E%3D2019-10-10

@smelc smelc requested a review from aherrmann March 13, 2020 10:30
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

A couple comments, and a few entries are missing links to the corresponding PRs.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@smelc
Copy link
Contributor Author

smelc commented Mar 14, 2020

A couple comments, and a few entries are missing links to the corresponding PRs.

Thanks @aherrmann, I double checked that all entries have links to PRs starting at cb537c2. I only left them out for the entry mentioning the addition of the three GHC bindist versions. It seemed overkill.

CHANGELOG.md Outdated
* `haskell_cabal_library`, `haskell_cabal_binary`, and `stack_snapshot`
now have a `verbose` argument, to allow suppressing their output.
See [#1208](https://github.com/tweag/rules_haskell/pull/1208).
* `haskell_cabal_library` and `stack_snapshot` now have a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and https://github.com/tweag/rules_haskell/pull/1279/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR40 could be merged into one entry as #1200 is just about making #1102 optional. Maybe something like

 * `haskell_cabal_library` and `stack_snapshot` now build the haddock documentation if the parameter `haddock` is set to `True` (the default).
  See [#1102](https://github.com/tweag/rules_haskell/pull/1102) and  [#1200](https://github.com/tweag/rules_haskell/pull/1200)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented this suggestion in 1191ebf

Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great!

@smelc smelc merged commit 19dbc7f into master Mar 16, 2020
@smelc smelc deleted the release-0.12 branch March 16, 2020 12:35
@smelc smelc restored the release-0.12 branch March 16, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants