-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 0.12: add changelog #1279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
A couple comments, and a few entries are missing links to the corresponding PRs.
Thanks @aherrmann, I double checked that all entries have links to PRs starting at cb537c2. I only left them out for the entry mentioning the addition of the three GHC bindist versions. It seemed overkill. |
CHANGELOG.md
Outdated
* `haskell_cabal_library`, `haskell_cabal_binary`, and `stack_snapshot` | ||
now have a `verbose` argument, to allow suppressing their output. | ||
See [#1208](https://github.com/tweag/rules_haskell/pull/1208). | ||
* `haskell_cabal_library` and `stack_snapshot` now have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this and https://github.com/tweag/rules_haskell/pull/1279/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR40 could be merged into one entry as #1200 is just about making #1102 optional. Maybe something like
* `haskell_cabal_library` and `stack_snapshot` now build the haddock documentation if the parameter `haddock` is set to `True` (the default).
See [#1102](https://github.com/tweag/rules_haskell/pull/1102) and [#1200](https://github.com/tweag/rules_haskell/pull/1200)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented this suggestion in 1191ebf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great!
Release checklist: #1278
For the record, I gathered the list of PRs since release 0.11 here: https://github.com/tweag/rules_haskell/pulls?q=is%3Apr+merged%3A%3E%3D2019-10-10