Use bazel 6 in the CI #1911
Merged
Use bazel 6 in the CI #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ylecornec/incompatible_disable_starlark_host_transitions
to
master
June 23, 2023 09:56
|
🎉 All dependencies have been resolved ! |
- Use the same version of go with bindist as with nix - Use go toolchain from rules_nixpkgs in preparation for bzlmod support because it is not possible to use `is_nix_shell` in the MODULE.bazel file
nodejs-16_x is deprecated in recent nixpkgs versions
This will become the default in bazel 7
ylecornec
force-pushed
the
ylecornec/bazel_6
branch
from
7a4889f to
f15f0a9
Compare
Merged
avdv
reviewed
Jun 27, 2023
| @@ -48,13 +48,12 @@ rules_proto_dependencies() | |||
| rules_proto_toolchains() | |||
|
|
|||
| # For buildifier | |||
| # starting from 0.29, rules_go requires bazel >= 4.2.0 | |||
| http_archive( | |||
There was a problem hiding this comment.
@ylecornec do you know which Bazel version rules_go 0.39.1 requires? AFAIK, 0.35 requires at least Bazel 5.1, so we might want to note somewhere that we require at least version x.y for developing on this repo? Or just use a .bazelversion file?
There was a problem hiding this comment.
Ah indeed, it requires at least Bazel 5.3.
Release 0.38 is the one with the fix for incompatible_disable_starlark_host_transitions and requiring this version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1909.
This PR updates the CI to bazel version
6.2.1This is necessary to:
rules_goto a recent version and activate the--incompatible_disable_starlark_host_transitionsto hopefully resolve Flag --incompatible_disable_starlark_host_transitions will break rules_haskell in Bazel 7.0 #1846.Some notes:
nixpkgis updated to a version that contains bazel6.2.1.1.20, which requires updatingrules_goand rules_nixpkgs (to a version containing this fix).hostone. This is done in preparation for bzlmod because it is not possible to useis_nix_shellin theMODULE.bazelfile.