Restore short repository labels #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before #29, we'd write ```python nixpkgs_package(name = "hello", repository = "@nixpkgs") ``` and this would just work. Now we write ```python nixpkgs_package(name = "hello", repositories = { "nixpkgs": "@nixpkgs//:default.nix" }) ``` which is quite a bit more verbose. With this fix, writing the repository label as `"@nixpkgs"` works again. Fixes #41.
mboes
force-pushed
the
short-repo-refs
branch
from
8ae278f to
c837a42
Compare
Profpatsch
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #29, we'd write
and this would just work. Now we write
which is quite a bit more verbose. With this fix, writing the
repository label as
"@nixpkgs"works again.Fixes #41.