Safer sh_posix_configure on Windows #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autodetection using `repository_ctx.which` is not safe on Windows, as it may turn up false friends. E.g. Windows has a `find.exe` which is unrelated to POSIX `find`. Instead we use tools next to `bash.exe`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodetection using
repository_ctx.whichis not safe on Windows, as it may turn up false friends. E.g. Windows has afind.exewhich is unrelated to POSIXfind. Instead we follow the example of@bazel_tools//tools/sh:sh_configure.bzland use tools next tobash.exe.This repository currently doesn't have Windows CI. However,
rules_haskell's CI passes with these changes.