Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.4.1 #708

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Bump version to 0.4.1 #708

merged 1 commit into from
Jun 6, 2024

Conversation

yannham
Copy link
Member

@yannham yannham commented Jun 5, 2024

Prepare a release of topiary-queries with the latest Nickel queries to crates.io. For the time being, it was decided that it's ok to bump the patch version for such an update. I hesitated to do this just for topiary-queries, but that would mean to stop using the workspace version for topiary-queries, but the added risk of being out of sync (or to just forget to bump topiary-queries's version during an update) isn't worth it IMHO. Instead, I think we should just accept to bump the whole workspace version.

I don't know if a GitHub release is very useful to do in this case (or a cargo release of other Topiary crates). I think it's fine to keep all the others crates at 0.4.0 on GitHub and crates.io until the next update, and just publish topiary-queries. But I'm happy to do otherwise.

Checklist

Checklist before merging:

  • CHANGELOG.md updated
  • README.md up-to-date

Prepare a release of `topiary-queries` with the latest Nickel queries.
For the time being, it was decided that it's ok to bump the minor
version for such an update.
@yannham yannham force-pushed the chore/0.4.1-update branch from 40fc460 to dded060 Compare June 5, 2024 12:51
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...although note that I don't have a dog in this race, so YMMV 😅

@yannham
Copy link
Member Author

yannham commented Jun 5, 2024

Let's get a stamp of approval from @ErinvanderVeen as well, to be sure it's a consensus

@ErinvanderVeen
Copy link
Collaborator

This is good for now. I think in the future we want to decouple the versions if possible.

@yannham yannham merged commit 1f11bab into main Jun 6, 2024
9 checks passed
@yannham yannham deleted the chore/0.4.1-update branch June 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants