Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean cpu #22

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Clean cpu #22

wants to merge 31 commits into from

Conversation

GuyDSP
Copy link
Contributor

@GuyDSP GuyDSP commented Nov 18, 2024 •
edited
Loading

remove bloging files
update CoSApp class to respect good practices (like one class by file)
add pytest on CoSApp systems
update files to respect pre-commit
update licences
update requirments
run all notebooks (and add a pytest to run them)

@GuyDSP GuyDSP marked this pull request as draft November 18, 2024 17:11
@GuyDSP GuyDSP marked this pull request as ready for review November 18, 2024 17:12
adriendelsalle
adriendelsalle reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@adriendelsalle adriendelsalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clean-up
comments left inline

twiinit_demos/cpu/utils/display.py Outdated Show resolved Hide resolved
twiinit_demos/cpu/tests/test_systems.py Outdated Show resolved Hide resolved
twiinit_demos/Linardoe.ipynb Outdated Show resolved Hide resolved
twiinit_demos/MonteCarlo.ipynb Outdated Show resolved Hide resolved
twiinit_demos/blogging/global_optimization/Pipe analysis.ipynb Outdated Show resolved Hide resolved
twiinit_demos/blogging/global_optimization/pipe.py Outdated Show resolved Hide resolved
@GuyDSP GuyDSP changed the title [DRAFT] Clean cpu Clean cpu Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriendelsalle adriendelsalle adriendelsalle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuyDSP @adriendelsalle