Skip to content

Commit

Permalink
fix some broken links in the doc
Browse files Browse the repository at this point in the history
  • Loading branch information
chizhg committed Jun 12, 2020
1 parent f3dffec commit 985821e
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion docs/oss-oncall-log.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

"Oh yeah, I remember having to deal with that a while back... what was it again?"

See also: [post-mortems](./post-mortems.md)
See also: [post-mortems](/docs/post-mortems)

- Issue: bigquery metrics dashboard in velodrome.k8s.io is out of date ([#8703](https://github.com/kubernetes/test-infra/issues/8703))
- Symptoms:
Expand Down
2 changes: 1 addition & 1 deletion images/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ We have bazel images that have two versions of bazel installed. The upgrade proc

There is no automated testing pipeline for images:
- Any jobs that use the `:latest` tag use the latest published image immediately
- Any jobs that use a `:v{date}-{sha}[-{variant}]` tag (e.g. `:v20200407-c818676-master`) are updated to use the latest published image ~daily. This is accomplished by PR's created by the [autobumper prowjob](https://testgrid.k8s.io/sig-testing-prow#autobump-prow), which are merged by [test-infra oncall](go.k8s.io/oncall) once a day during weekdays.
- Any jobs that use a `:v{date}-{sha}[-{variant}]` tag (e.g. `:v20200407-c818676-master`) are updated to use the latest published image ~daily. This is accomplished by PR's created by the [autobumper prowjob](https://testgrid.k8s.io/sig-testing-prow#autobump-prow), which are merged by [test-infra oncall](https://go.k8s.io/oncall) once a day during weekdays.

1. Merge a PR changing something in the image directory.

Expand Down
2 changes: 1 addition & 1 deletion label_sync/labels.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ larger set of contributors to apply/remove them.
| <a id="lgtm" href="#lgtm">`lgtm`</a> | Indicates that a PR is ready to be merged.| reviewers or members | [lgtm](https://git.k8s.io/test-infra/prow/plugins/lgtm) |
| <a id="needs-kind" href="#needs-kind">`needs-kind`</a> | Indicates a PR lacks a `kind/foo` label and requires one.| prow | [require-matching-label](https://git.k8s.io/test-infra/prow/plugins/require-matching-label) |
| <a id="needs-ok-to-test" href="#needs-ok-to-test">`needs-ok-to-test`</a> | Indicates a PR that requires an org member to verify it is safe to test.| prow | [trigger](https://git.k8s.io/test-infra/prow/plugins/trigger) |
| <a id="needs-rebase" href="#needs-rebase">`needs-rebase`</a> | Indicates a PR cannot be merged because it has merge conflicts with HEAD.| prow | [needs-rebase](https://git.k8s.io/test-infra/prow/plugins/needs-rebase) |
| <a id="needs-rebase" href="#needs-rebase">`needs-rebase`</a> | Indicates a PR cannot be merged because it has merge conflicts with HEAD.| prow | [needs-rebase](https://git.k8s.io/test-infra/prow/external-plugins/needs-rebase) |
| <a id="ok-to-test" href="#ok-to-test">`ok-to-test`</a> | Indicates a non-member PR verified by an org member that is safe to test.| prow | [trigger](https://git.k8s.io/test-infra/prow/plugins/trigger) |
| <a id="release-note" href="#release-note">`release-note`</a> | Denotes a PR that will be considered when it comes time to generate release notes.| prow | [releasenote](https://git.k8s.io/test-infra/prow/plugins/releasenote) |
| <a id="release-note-action-required" href="#release-note-action-required">`release-note-action-required`</a> | Denotes a PR that introduces potentially breaking changes that require user action.| prow | [releasenote](https://git.k8s.io/test-infra/prow/plugins/releasenote) |
Expand Down
2 changes: 1 addition & 1 deletion label_sync/labels.md.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ larger set of contributors to apply/remove them.
| Name | Description | Added By | Prow Plugin |
| ---- | ----------- | -------- | --- |
{{ range $labelData.Labels -}}
| <a id="{{ anchor .Name }}" href="#{{ anchor .Name }}">`{{ .Name }}`</a> | {{ if .DeleteAfter -}} REMOVING. This will be deleted after {{ .DeleteAfter }} <br><br> {{ end -}} {{ .Description }} {{- if .Previously }} <br><br> This was previously {{ range .Previously -}} `{{.Name }}`, {{ end -}} {{ end -}} | {{.AddedBy }} | {{ if .ProwPlugin }} [{{.ProwPlugin}}](https://git.k8s.io/test-infra/prow/plugins/{{.ProwPlugin}}) {{ end }}|
| <a id="{{ anchor .Name }}" href="#{{ anchor .Name }}">`{{ .Name }}`</a> | {{ if .DeleteAfter -}} REMOVING. This will be deleted after {{ .DeleteAfter }} <br><br> {{ end -}} {{ .Description }} {{- if .Previously }} <br><br> This was previously {{ range .Previously -}} `{{.Name }}`, {{ end -}} {{ end -}} | {{.AddedBy }} | {{ if .ProwPlugin }} [{{.ProwPlugin}}](https://git.k8s.io/test-infra/prow/{{ if .IsExternalPlugin }}external-{{ end }}plugins/{{.ProwPlugin}}) {{ end }}|
{{ end }}
{{ end }}
1 change: 1 addition & 0 deletions label_sync/labels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ default:
name: needs-rebase
target: prs
prowPlugin: needs-rebase
isExternalPlugin: true
addedBy: prow
- color: ededed
description: Indicates an issue or PR lacks a `sig/foo` label and requires one.
Expand Down
2 changes: 2 additions & 0 deletions label_sync/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ type Label struct {
Target LabelTarget `json:"target"`
// ProwPlugin specifies which prow plugin add/removes this label
ProwPlugin string `json:"prowPlugin"`
// IsExternalPlugin specifies if the prow plugin is external or not
IsExternalPlugin bool `json:"isExternalPlugin"`
// AddedBy specifies whether human/munger/bot adds the label
AddedBy string `json:"addedBy"`
// Previously lists deprecated names for this label
Expand Down
2 changes: 1 addition & 1 deletion prow/plugins/approve/approvers/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ K8s-bot updates comment:
You can indicate your approval by writing `/approve` in a comment
You can cancel your approval by writing `/approve cancel` in a comment

The PR is now unblocked from merging. If [Tide](../../cmd/tide) is configured, the K8s-bot merges the PR, because it has both the **lgtm** and **approved**. It K8s-bot still needs to wait its turn in submit queue and pass tests.
The PR is now unblocked from merging. If [Tide](/prow/cmd/tide) is configured, the K8s-bot merges the PR, because it has both the **lgtm** and **approved**. It K8s-bot still needs to wait its turn in submit queue and pass tests.

![Bot Notification for Approval Mechanism](images/bot_notification_for_approval_selection_mechanism.png)

Expand Down
2 changes: 1 addition & 1 deletion prow/pod-utilities.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Writing a ProwJob that uses the Pod Utilities is much easier than writing one
that doesn't because the Pod Utilities will transparently handle many of the
tasks the job would otherwise need to do in order to prepare its environment
and output more than pass/fail. Historically, this was achieved by wrapping
every job with a [bootstrap.py](jenkins/bootstrap.py) script that handled cloning
every job with a [bootstrap.py](/jenkins/bootstrap.py) script that handled cloning
source code, preparing the test environment, and uploading job metadata, logs,
and artifacts. This was cumbersome to configure and required every job to be
wrapped with the script in the job image. The pod utilities achieve the same goals
Expand Down
2 changes: 1 addition & 1 deletion testgrid/conformance/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ For running the conformance tests and obtaining the result files (`b)` and `c)`)
```
- You can then find the log file and JUnit at `./e2e.log` and `./_artifacts/junit_01.xml` respectively.

- or use the [Sonobuouy CLI](https://github.com/heptio/sonobuoy#using-the-cli) to run the tests and then obtain a "snapshot" with the official instructions [when run locally](https://github.com/heptio/sonobuoy#download-and-run). You can then get the e2e log and JUnit from the snapshot (see the [plugins section](https://github.com/heptio/sonobuoy/blob/master/docs/snapshot.md#plugins) of the snapshot documentation)
- or use the [Sonobuouy CLI](https://github.com/heptio/sonobuoy#using-the-cli) to run the tests and then obtain a "snapshot" with the official instructions [when run locally](https://github.com/heptio/sonobuoy#download-and-run). You can then get the e2e log and JUnit from the snapshot (see the [plugins section](https://github.com/heptio/sonobuoy/blob/master/site/docs/master/snapshot.md#plugins) of the snapshot documentation)

For uploading the results (`d)`) you can use the tooling provided here (or build your own mimicking it), to use `upload_e2e.py` provide the following required flags:
- `--junit` -- The path to the JUnit result file(s): `--junit=/path/to/junit/result/file/junit_01.xml`
Expand Down

0 comments on commit 985821e

Please sign in to comment.