Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix exit code regression #199

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: fix exit code regression #199

merged 1 commit into from
Feb 15, 2022

Conversation

Sindhura3
Copy link
Contributor

@Sindhura3 Sindhura3 commented Feb 14, 2022

Fixes

Fixes DII-163
This is a regression from #142. Formatting the exit code early failed a check for access denied status. Due to this, the correct error message was not getting displayed to the end user.

Screenshot 2022-02-14 at 9 59 38 PM

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Sindhura3 Sindhura3 merged commit fab52aa into main Feb 15, 2022
@Sindhura3 Sindhura3 deleted the fix-exit-code-regression branch February 15, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants