Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Modifying make command to take project name and token as arguments for reuse #634

Merged
merged 17 commits into from
Sep 27, 2022
Merged

test: Modifying make command to take project name and token as arguments for reuse #634

merged 17 commits into from
Sep 27, 2022

Conversation

AsabuHere
Copy link
Contributor

@AsabuHere AsabuHere commented Sep 27, 2022 •
edited
Loading

Fixes

DII-640 Setup Mono repo for twilio-oai-generator (examples folder)
A short description of what this PR does.
Modifying make command to take project name and token as arguments for reuse. This will be used from twilio oai generator repo for testing generated C# files

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@AsabuHere AsabuHere changed the title Testing csharp monorepo fix: Modifying make command to take project name and token as arguments for reuse Sep 27, 2022
@childish-sambino childish-sambino changed the title fix: Modifying make command to take project name and token as arguments for reuse test: Modifying make command to take project name and token as arguments for reuse Sep 27, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AsabuHere AsabuHere merged commit cfc8390 into main Sep 27, 2022
@AsabuHere AsabuHere deleted the asabu_monorepo_testing branch September 27, 2022 17:20
Swimburger pushed a commit to Swimburger/twilio-csharp that referenced this pull request Dec 28, 2022
@AsabuHere @Swimburger
test: Modifying make command to take project name and token as argume…
d7648f1 
…nts for reuse (twilio#634)

* Making changes in make command to take project key as an argument for sonar analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

@kridai kridai Awaiting requested review from kridai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsabuHere @childish-sambino