fix: Do not include null values in JWT payloads #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
difficulty: easy
| @@ -336,4 +338,18 @@ public void testVoiceTokenWithoutIncoming() { | |||
| Assert.assertEquals("AP123", outgoing.get("application_sid")); | |||
| Assert.assertEquals("bar", outgoingParams.get("foo")); | |||
| } | |||
|
|
|||
| @Test() | |||
| public void testNullValues() throws JsonProcessingException { | |||
There was a problem hiding this comment.
Changes looks fine, but there's a lot of duplicated code in this test class. Could you refactor the obvious bits? Also, the other tests use a JWT parser to validate the payload rather than an object mapper. I prefer making this one uniform with the others so we know the payload conforms rather than what an object mapper produces.
childish-sambino
approved these changes
Feb 10, 2020
FalguniV
pushed a commit
to FalguniV/twilio-java
that referenced
this pull request
Oct 13, 2020
FalguniV
pushed a commit
to FalguniV/twilio-java
that referenced
this pull request
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JWT payloads should not contain null values. This fix ensures any null values do not get included when serializing the
Payloadclass.Reference: https://www.baeldung.com/jackson-ignore-null-fields
Checklist