Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RecordingRule and RecordingRulesUpdate #573

Merged
merged 6 commits into from
Oct 13, 2020
Merged

feat: Add RecordingRule and RecordingRulesUpdate #573

merged 6 commits into from
Oct 13, 2020

Conversation

FalguniV
Copy link
Contributor

@FalguniV FalguniV commented Sep 2, 2020 •
edited
Loading

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious changed the title Add RecordingRule and RecordingRulesUpdate feat: Add RecordingRule and RecordingRulesUpdate Sep 9, 2020
@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap labels Sep 9, 2020
thinkingserious
thinkingserious requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@FalguniV FalguniV force-pushed the recordingRules branch 2 times, most recently from 7e6b29e to 3d5b4e6 Compare October 13, 2020 03:21
@FalguniV FalguniV force-pushed the recordingRules branch 3 times, most recently from e7e1a1e to 06f401e Compare October 13, 2020 04:11
@FalguniV FalguniV force-pushed the recordingRules branch 4 times, most recently from 3d548d9 to 1aa7026 Compare October 13, 2020 18:25
@childish-sambino childish-sambino merged commit db8caac into twilio:main Oct 13, 2020
@FalguniV FalguniV deleted the recordingRules branch October 13, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerverse innerverse innerverse approved these changes

@thinkingserious thinkingserious thinkingserious requested changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FalguniV @innerverse @thinkingserious @childish-sambino