fix: add non null values to param list #727

charan678 · 2023-01-27T14:06:52Z

Fixes

Add null value check before adding to params list
This check will reduce the huge list of checks in addPostParams,addQueryParams,AddHeaderParams

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

childish-sambino · 2023-01-27T14:53:46Z

src/main/java/com/twilio/http/Request.java

+        if (value == null)
+            return;


Could this be moved to the addParam method instead of repeated?

Yes thought about this but confused about the reason to create these wrapper function over addParams, so I added the null checks in wrapper but agree it's breaking DRY principle. Anyways made the changes