Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: protected NetworkHttpClient field #735

Merged
merged 2 commits into from
Mar 14, 2023
Merged

chore: protected NetworkHttpClient field #735

merged 2 commits into from
Mar 14, 2023

Conversation

bcanseco
Copy link
Member

Fixes

This is a similar PR to #631.

This PR changes the access modifier for the NetworkHttpClient's client field from private to protected. Allows for extending classes to use this overridden field (e.g. if you'd want your own custom NetworkHttpClient to have a request method that sends as JSON instead of URL-encoded, but want everything else to be the same).

Verified that make test passes but haven't added any additional tests since it's just a simple access change / would just be testing a core Java feature. Lmk if we do want a test for this and I'd be happy to write something up.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Allows for subclasses to use the field.
Copy link

@Hunga1 Hunga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hunga1
Copy link

Hunga1 commented Mar 14, 2023

Just need to update the branch with the base.

@Hunga1 Hunga1 merged commit b5076e1 into twilio:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants