chore: protected NetworkHttpClient field #735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This is a similar PR to #631.
This PR changes the access modifier for the NetworkHttpClient's
client
field fromprivate
toprotected
. Allows for extending classes to use this overridden field (e.g. if you'd want your own custom NetworkHttpClient to have a request method that sends as JSON instead of URL-encoded, but want everything else to be the same).Verified that make test passes but haven't added any additional tests since it's just a simple access change / would just be testing a core Java feature. Lmk if we do want a test for this and I'd be happy to write something up.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.