Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update reserved words #272

Merged
merged 2 commits into from
Oct 13, 2022
Merged

fix: update reserved words #272

merged 2 commits into from
Oct 13, 2022

Conversation

childish-sambino
Copy link
Contributor

@sbansla
Copy link
Contributor

sbansla commented Oct 13, 2022

Thanks for refactoring this, I was planning to do this.
Is it possible different language can have different reserved keywords ?

@sonarqubecloud
Copy link

[twilio-oai-generator] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@childish-sambino
Copy link
Contributor Author

@sbansla Yes, it's possible. Right now the abstract code gens construct the list of keywords which is different for each language. But the ones I've removed applied to multiple languages. If more are needed, they can be added in the individual language codegens.

@childish-sambino childish-sambino merged commit 8c7a0c0 into main Oct 13, 2022
@childish-sambino childish-sambino deleted the reserved-words branch October 13, 2022 17:29
kridai pushed a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants