-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: provide application/json support in request body #799
Conversation
UPGRADE.md
Outdated
@@ -2,6 +2,11 @@ | |||
|
|||
_MAJOR version bumps will have upgrade notes posted here._ | |||
|
|||
[2023-03-25] 7.x.x to 8.x.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 8.0.0-rc.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes correct, I'll do this
@@ -0,0 +1,97 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are generating these files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding them for the first time so that tests do not fail, similar to what we did in case of python.
Moving ahead, it will be autogenerated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suppose if a new API is added from api-definitions, Do we need to do this at that time ?
* chore: provide application/json support in request body (#799) * fix: added support for json content type * chore: added static files for preview messaging * chore: corrected name casing * chore: upgrade guide and changelog updated * chore: updated rc in VersionInfo.php * chore: updated rc version * feat!: MVR preparation (#802) * docs: added messaging bulk example * docs: corrected text message * feat!: MVR preparation --------- Co-authored-by: Twilio <[email protected]>
Fixes
Provides application/json type suport for request body
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.