Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup useless sys.version_info checks #852

Closed
tristanlatr opened this issue Dec 9, 2024 · 0 comments · Fixed by #853
Closed

Cleanup useless sys.version_info checks #852

tristanlatr opened this issue Dec 9, 2024 · 0 comments · Fixed by #853

Comments

@tristanlatr
Copy link
Contributor

tristanlatr commented Dec 9, 2024

We just drop Python 3.8 but I did not cleaned-up all legacy code.

pydoctor/pydoctor/test/test_astbuilder.py (these are inside test cases source, so it's not dead code)
2171,8: if sys.version_info > (3,7):
2252,20: if sys.version_info > (3,0):
2254,22: elif sys.version_info > (2,6):
2293,20: if sys.version_info < (3,7):
2314,8: if sys.version_info > (3,0):

pydoctor/pydoctor/test/test_twisted_python_deprecate.py
197,8: if sys.version_info>(3.8):

pydoctor/pydoctor/astbuilder.py
29,4: if sys.version_info >= (3,8):

pydoctor/pydoctor/astutils.py
235,8: if sys.version_info >= (3,8):
492,25: _string_lineno_is_end = sys.version_info < (3,8)
500,8: if sys.version_info >= (3,8):
520,8: if sys.version_info >= (3,8):
536,8: if sys.version_info >= (3,8):
567,8: if sys.version_info >= (3,8):

pydoctor/pydoctor/model.py
58,25: _string_lineno_is_end = sys.version_info < (3,8) \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant