Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require internet connexion to run configparser tests #854

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tristanlatr
Copy link
Contributor

fixes #841

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (aee7e81) to head (dfde970).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #854   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          47       47           
  Lines        8468     8468           
  Branches     1550     1550           
=======================================
  Hits         7858     7858           
  Misses        350      350           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tristanlatr tristanlatr marked this pull request as ready for review December 9, 2024 21:13
@tristanlatr
Copy link
Contributor Author

tristanlatr commented Dec 9, 2024

Actually we can now use the upstream version of these parser, which is included in configargparse since version 1.5.5: bw2/ConfigArgParse@v1.5.3...1.5.5 .

The only thing is that the code got merged without the tests, so I'll need to migrate the tests over the configargparse repo first.

Edit: actually since configparser has not received the patch to use the standard library module tomllib, we can’t use it right away. So I’ll merge that and open another issue.

@tristanlatr tristanlatr merged commit de81dcd into master Dec 11, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some test needs internet connexion
1 participant