Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One check job #292

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 19 additions & 27 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
test:
name: ${{ matrix.task.name}} - ${{ matrix.os.name }} ${{ matrix.python.name }}
name: Test - ${{ matrix.os.name }} ${{ matrix.python.name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Test - ${{ matrix.os.name }} ${{ matrix.python.name }}
name: ${{ matrix.python.name }} ${{ matrix.os.name }} tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-dev/pytest-twisted#108 Is my 'plan' to address the OS name (🐧, 🪟, 🍎). I guess the empty box I get instead of the window character is actually kind of like an ultra simplistic window so maybe I should just merge that. Python names could be more like the ABI tags (https://www.python.org/dev/peps/pep-0425/#abi-tag). So, cp27 and pp3 etc.

Should I try a setup like this in an effort to allow all info to be visible even in the short little space provided in the popup you shared? Rather than shuffling around what you get to see.

runs-on: ${{ matrix.os.runs-on }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -45,9 +45,6 @@ jobs:
- name: PyPy 3
tox: pypy3
action: pypy3
task:
- name: Test
tox: tests
exclude:
# Twisted and thus trial do not work on Windows with CPython 3.9.
# This will be fixed with the next release.
Expand Down Expand Up @@ -75,45 +72,40 @@ jobs:

- name: Codecov
run: |
codecov -n "GitHub Actions - ${{ matrix.task.name}} - ${{ matrix.os.name }} ${{ matrix.python.name }}"
codecov -n "GitHub Actions - Test - ${{ matrix.os.name }} ${{ matrix.python.name }}"

check:
name: ${{ matrix.task.name}} - ${{ matrix.python.name }}
name: Check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename Static checks ? 'Check is a bit generic'

Suggested change
name: Check
name: Static checks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems counter to being short. :] Is there really not a single word that has the desired meaning? It seems it only needs to be distinct from 'test'.

runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python:
# Using second most recent minor release for whatever little
# increase in stability over using the latest minor.
- name: CPython 3.8
tox: py38
action: 3.8
task:
- name: Flake8
tox: flake8
- name: Check Manifest
tox: check-manifest
- name: Check Newsfragment
tox: check-newsfragment

steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Set up ${{ matrix.python.name }}
uses: actions/setup-python@v2
- uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python.action }}
# Using second most recent minor release for whatever little
# increase in stability over using the latest minor.
python-version: 3.8

- uses: twisted/[email protected]

- name: Install dependencies
id: last_step_before_checks
run: python -m pip install --upgrade pip tox

- name: Check
run: tox -c tox.ini -e ${{ matrix.task.tox }}
- name: Lint
if: always()
run: tox -c tox.ini -e flake8

- name: Manifest
if: always()
run: tox -c tox.ini -e check-manifest

- name: Newsfragment
if: always()
run: tox -c tox.ini -e check-newsfragment

all:
name: All
Expand Down
Empty file.