-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One check job #292
One check job #292
Changes from all commits
e78fa7a
e3bb91c
2aaf78e
2c93934
5add44c
7df3da4
4ddc02f
724c8f9
05fec2a
133516e
a41272a
9164b58
0969624
7fe3611
4c95802
f1fe33b
f0db0e3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -8,7 +8,7 @@ on: | |||||
|
||||||
jobs: | ||||||
test: | ||||||
name: ${{ matrix.task.name}} - ${{ matrix.os.name }} ${{ matrix.python.name }} | ||||||
name: Test - ${{ matrix.os.name }} ${{ matrix.python.name }} | ||||||
runs-on: ${{ matrix.os.runs-on }} | ||||||
strategy: | ||||||
fail-fast: false | ||||||
|
@@ -45,9 +45,6 @@ jobs: | |||||
- name: PyPy 3 | ||||||
tox: pypy3 | ||||||
action: pypy3 | ||||||
task: | ||||||
- name: Test | ||||||
tox: tests | ||||||
exclude: | ||||||
# Twisted and thus trial do not work on Windows with CPython 3.9. | ||||||
# This will be fixed with the next release. | ||||||
|
@@ -75,45 +72,40 @@ jobs: | |||||
|
||||||
- name: Codecov | ||||||
run: | | ||||||
codecov -n "GitHub Actions - ${{ matrix.task.name}} - ${{ matrix.os.name }} ${{ matrix.python.name }}" | ||||||
codecov -n "GitHub Actions - Test - ${{ matrix.os.name }} ${{ matrix.python.name }}" | ||||||
|
||||||
check: | ||||||
name: ${{ matrix.task.name}} - ${{ matrix.python.name }} | ||||||
name: Check | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe rename
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems counter to being short. |
||||||
runs-on: ubuntu-latest | ||||||
strategy: | ||||||
fail-fast: false | ||||||
matrix: | ||||||
python: | ||||||
# Using second most recent minor release for whatever little | ||||||
# increase in stability over using the latest minor. | ||||||
- name: CPython 3.8 | ||||||
tox: py38 | ||||||
action: 3.8 | ||||||
task: | ||||||
- name: Flake8 | ||||||
tox: flake8 | ||||||
- name: Check Manifest | ||||||
tox: check-manifest | ||||||
- name: Check Newsfragment | ||||||
tox: check-newsfragment | ||||||
|
||||||
steps: | ||||||
- uses: actions/checkout@v2 | ||||||
with: | ||||||
fetch-depth: 0 | ||||||
|
||||||
- name: Set up ${{ matrix.python.name }} | ||||||
uses: actions/setup-python@v2 | ||||||
- uses: actions/setup-python@v2 | ||||||
with: | ||||||
python-version: ${{ matrix.python.action }} | ||||||
# Using second most recent minor release for whatever little | ||||||
# increase in stability over using the latest minor. | ||||||
python-version: 3.8 | ||||||
|
||||||
- uses: twisted/[email protected] | ||||||
|
||||||
- name: Install dependencies | ||||||
id: last_step_before_checks | ||||||
run: python -m pip install --upgrade pip tox | ||||||
|
||||||
- name: Check | ||||||
run: tox -c tox.ini -e ${{ matrix.task.tox }} | ||||||
- name: Lint | ||||||
if: always() | ||||||
run: tox -c tox.ini -e flake8 | ||||||
|
||||||
- name: Manifest | ||||||
if: always() | ||||||
run: tox -c tox.ini -e check-manifest | ||||||
|
||||||
- name: Newsfragment | ||||||
if: always() | ||||||
run: tox -c tox.ini -e check-newsfragment | ||||||
|
||||||
all: | ||||||
name: All | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest-dev/pytest-twisted#108 Is my 'plan' to address the OS name (🐧, 🪟, 🍎). I guess the empty box I get instead of the window character is actually kind of like an ultra simplistic window so maybe I should just merge that. Python names could be more like the ABI tags (https://www.python.org/dev/peps/pep-0425/#abi-tag). So, cp27 and pp3 etc.
Should I try a setup like this in an effort to allow all info to be visible even in the short little space provided in the popup you shared? Rather than shuffling around what you get to see.