Use jobslot instead of dep jobserver
#371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
For bugfix and optimization. Signed-off-by: Jiahao XU <[email protected]>
|
cc <= 1.0.79 still pulls in jobserver, hence why the msrv failed |
|
Yep, working on it :) |
|
This is now in master, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiahao XU [email protected]
This PR replaces dep
jobserverwith a forkjobslot.Advantages over
jobserver?jobslotcontains bug fix for Client::configure is unsafejobslotremoved use of signal handling in the helper thread on unixjobslotuseswinapion windows instead of manually declaring bindings (some of the bindings seem to be wrong)jobslotusesgetrandomon windows instead of making homebrew one using raw windows api