Support scrooge-generator compiler flags in thrift_library rule #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blorente @wisechengyi |
wisechengyi
approved these changes
Nov 24, 2020
|
looks like there's some minor formatting issue from travis otherwise this is good to go. |
blorente
pushed a commit
that referenced
this pull request
Nov 26, 2020
* Add option parsing file * Add OptionParser * Add scopt dependency * Lint reformat
blorente
pushed a commit
that referenced
this pull request
Feb 22, 2021
* Add option parsing file * Add OptionParser * Add scopt dependency * Lint reformat
cattibrie
added a commit
to cattibrie/rules_scala
that referenced
this pull request
Feb 23, 2021
…ter-forks#6) * Add option parsing file * Add OptionParser * Add scopt dependency * Lint reformat
cattibrie
added a commit
to cattibrie/rules_scala
that referenced
this pull request
Mar 8, 2021
…lbuild#1228) * Support scrooge-generator compiler flags in thrift_library rule (twitter-forks#6) * Add option parsing file * Add OptionParser * Add scopt dependency * Lint reformat * Add option parsing file * Add scopt dependency * Lint reformat * Add test for compiler_args in thrift_library * Fix lint error * Remove option parser from rules_scala code * Add scopt dependency * Update test and clean code
wisechengyi
pushed a commit
that referenced
this pull request
Mar 11, 2021
…lbuild#1228) * Support scrooge-generator compiler flags in thrift_library rule (#6) * Add option parsing file * Add OptionParser * Add scopt dependency * Lint reformat * Add option parsing file * Add scopt dependency * Lint reformat * Add test for compiler_args in thrift_library * Fix lint error * Remove option parser from rules_scala code * Add scopt dependency * Update test and clean code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Currently passing compiler args to scrooge_generator is not supported in rules_scala.
Add
compiler_argsargument tothrift_libraryrule.Use scopt option parser to parse compiler flags.
The option parsing is copy-pasted from Twitter scrooge-generator.
The copy-pasted code will be removed when the Twitter scrooge-generator version with these changes is released.
Update Compiler with the latest changes in scrooge-generator Compiler.
TODO: add tests that check that
compiler_argsset on a thrift_library target are used by scrooge-generator.