Added Aggregators for BloomFilter, CountMinSketch, MapSketch, HyperLogLog, Moments, Min, Max #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val monoid = hllMonoid | ||
|
|
||
| def prepare(value: Array[Byte]) = monoid.create(value) | ||
| def present(hll: HLL) = hll |
There was a problem hiding this comment.
Does present want to be the HLL here, or the estimate? I can see arguments either way.
There was a problem hiding this comment.
I think the estimate would be the nicer output but I'm not actually using HLL so I don't know how useful others would find having the actual HLL instance.
|
Nice work. Really appreciate this! Make a few return types and I'll merge. |
| } | ||
| } | ||
|
|
||
| case class HyperLogLogAggregator(val hllMonoid: HyperLogLogMonoid) extends MonoidAggregator[Array[Byte], HLL, Double] { |
There was a problem hiding this comment.
We often store the HLL. Let's keep the HLL as the return type and if you want size you can use
.andThenPresent(_.estimateSize)to get it.
There was a problem hiding this comment.
If you also want a size estimating one, that's fine, HLLSizeAggregator or something, so you don't have to do the above andThen over and over.
* Fixed return types. * Added aggregator that returns HLL size.
|
Looks good. Thanks! |
johnynek
added a commit
that referenced
this pull request
Sep 30, 2013
Added Aggregators for BloomFilter, CountMinSketch, MapSketch, HyperLogLog, Moments, Min, Max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Aggregators for BloomFilter, CountMinSketch, MapSketch, HyperLogLog, Moments, Min, Max with some testing. Are there any other classes that should also have aggregators added?
This should address #190.