Add performance improvements with reference mutable map implementation, and benchmarks #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e some println's from the code
jcoveney
changed the title
|
|
||
| /** | ||
| * @author Ian O Connell | ||
| */ |
There was a problem hiding this comment.
could you add a short description here?
| extends AsyncSummer[(Key, Value), Map[Key, Value]] | ||
| with WithFlushConditions[(Key, Value), Map[Key, Value]] { | ||
|
|
||
|
|
||
| private class MapContainer private (val next: Value, privBuf: ListBuffer[Value], var elementsCommitted: Int) { |
There was a problem hiding this comment.
Let's add a TODO: I think this algorithm is not using mutability. It could work almost exactly the same with List[Value] and vals everywhere.
johnynek
added a commit
that referenced
this pull request
Apr 18, 2014
Add performance improvements with reference mutable map implementation, and benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geeking out! add's mostly performance improvements along with a reference mutable map implementation. Also adds a benchmark to track the perf of these