Feature/auto formatter ran #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| */ | ||
| object AdaptiveVector { | ||
| /** When density >= this value * size, we switch to dense vectors | ||
| /** |
There was a problem hiding this comment.
this change means something different in javadoc. The stuff on the first line is the summary, the rest is the detailed comments, I believe. Is that not correct?
There was a problem hiding this comment.
My understanding from wikipedia just now is that the first line, (on or after the opening of the comment) is the summary. then it expects a blank line or new paragraph to be the detailed
There was a problem hiding this comment.
BTW with this change in place the scaladoc for this constant looks ok
|
merge when green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just as a sample -- we will need to control what outstanding branches we have if we want to use this to avoid merge pain.