-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverageAggregate #414
Conversation
lgtm, merge when green |
This is good but we fail when we upload results to coveralls: |
Sorry my bad, git foo on cmd line broke stuff and closed all of these |
It looks like the tests take too long to run when doing the coverage tracking. Maybe we can turn down the number of trials in the CMS tests. They seem to be the slow ones in my check: Maybe we can turn down the number of instances on some of these? |
I think it is actually working now: https://coveralls.io/github/twitter/algebird |
@ianoc I guess this is green now, and we can start showing code coverage. Merge? |
Nice. Does it also work if the tests are in a separate package now? |
scoverage/sbt-scoverage#87 is still open. |
The code coverage values don't look right do they? It also reports on that website that develop was tested/updated last night. But we've made no changes there. Looking at the results on that coverage page it seems to report only 28 files are covered... none of which are from algebird-core from what i can see. |
about develop: I think that is travis test of the push. It looks like aggregate testing is indeed broken still. I guess we need a later sbt-coverage plugin, but it appears the coveralls support is lagging, and does not yet support sbt-coverage 1.3.3. I guess algebird is a uniquely bad case here because all the tests are in another package. I guess we could try codecov: https://codecov.io/guide Have to say, this is pretty frustrating shit. We've been trying this for a year or more. |
Closing, since we now have codecov. |
We need this to get better, but still not accurate, results due to: scoverage/sbt-scoverage#87