Add MapAggregator from 1 (key, aggregator) pair #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidma
force-pushed
the
features/map-aggregator-with-one-entry
branch
from
a431f83 to
e83e669
Compare
|
|
||
| // there's no Semigroup[Tuple1[T]], so just use T as intermediary type instead of Tuple1[T] | ||
| val aggregatorForOneItem = s""" | ||
| |def apply[A, B, C](aggDef: (String, ${aggType}Aggregator[A, B, C])): ${aggType}Aggregator[A, B, Map[String, C]] = { |
There was a problem hiding this comment.
can this be (K, ${aggType}Aggregator[A, B, C]) so it matches the others? We should not require a String as the key, I don't think.
- Make API easier to use (more consistent), by allowing to create a MapAggregator of one "metric"
vidma
force-pushed
the
features/map-aggregator-with-one-entry
branch
from
e83e669 to
cca1349
Compare
|
looks like this is hung on coveralls, trying to fix this issue here: #458 |
johnynek
added a commit
that referenced
this pull request
Jun 26, 2015
…ntry Add MapAggregator from 1 (key, aggregator) pair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves: #411 (comment)