add immutable version of sorted(Reverse)Take #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test(s)? |
| @@ -87,3 +87,9 @@ class TopKMonoid[T](k: Int)(implicit ord: Ordering[T]) extends Monoid[TopK[T]] { | |||
| TopK(size, reversed, max) | |||
| } | |||
| } | |||
|
|
|||
| class TopKToListAggregator[A](max: Int)(implicit ord: Ordering[A]) extends MonoidAggregator[A, TopK[A], List[A]] { | |||
| override def monoid: Monoid[TopK[A]] = new TopKMonoid[A](max)(ord) | |||
There was a problem hiding this comment.
can we make this a val? the def will allocate on each access.
|
@ianoc I see that both |
|
If none of the other aggregators are covered thats fine. I was just hoping it would be a 1 - 2 line addition. Oh well |
|
LGTM, thanks! |
ianoc
added a commit
that referenced
this pull request
Aug 18, 2015
add immutable version of sorted(Reverse)Take
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.